Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: logging in intel_rdt.go caused service stop timeout even as root (#9844) #9850

Merged
merged 1 commit into from
Oct 4, 2021
Merged

fix: logging in intel_rdt.go caused service stop timeout even as root (#9844) #9850

merged 1 commit into from
Oct 4, 2021

Conversation

guoqiao
Copy link
Contributor

@guoqiao guoqiao commented Oct 1, 2021

Required for all PRs:

  • Updated associated README.md.
  • Wrote appropriate unit tests.
  • Pull request title or commits are in conventional commit format (e.g. feat: or fix:)

resolves #9844

when intel_rdt plugin enabled, service stop telegraf will timeout even when telegraf service is running as root.
This patch fixes it.

@guoqiao
fix: logging in intel_rdt.go caused service stop timeout even as root (…
5760786 
…influxdata#9844)

when intel_rdt plugin enabled, `service stop telegraf` will timeout even when telegraf service is running as root.

This patch fixes it.

Fixes: influxdata#9844

Signed-off-by: Joe Guo <joe.guo@canonical.com>
@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Oct 1, 2021
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Oct 1, 2021

Looks like new artifacts were built from this PR. Get them here!

Artifact URLs

@guoqiao guoqiao mentioned this pull request Oct 2, 2021
Merged
2 tasks
srebhan
srebhan approved these changes Oct 2, 2021
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @guoqiao for looking into this issue!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Oct 2, 2021
@srebhan srebhan self-assigned this Oct 2, 2021
@srebhan srebhan added fix pr to fix corresponding bug and removed feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin labels Oct 2, 2021
@powersj powersj merged commit 6c1bdfa into influxdata:master Oct 4, 2021
@guoqiao
Copy link
Contributor Author

guoqiao commented Oct 4, 2021

@srebhan and @powersj , thank you!

reimda pushed a commit that referenced this pull request Oct 6, 2021
@guoqiao @reimda
fix: logging in intel_rdt.go caused service stop timeout even as root (…
c95a1bc 
…#9844) (#9850)

(cherry picked from commit 6c1bdfa)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan approved these changes

@powersj powersj powersj approved these changes

Assignees

@srebhan srebhan

Labels
fix pr to fix corresponding bug ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

telegraf can not stop gracefully when intel_rdt plugin enabled, even running as root
3 participants
@guoqiao @powersj @srebhan