-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: revert reset of ticker #9800
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reimda
reviewed
Sep 23, 2021
…r batch is ready. (influxdata#8953)" This reverts commit a6d2c4f.
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
powersj
changed the title
fix: do not reset ticker on batch write
fix: revert reset of ticker
Sep 24, 2021
This was
linked to
issues
Oct 1, 2021
I've installed binary from this PR and it resolved mine #9802 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert the previous PR. In scenarios where inputs fill the batch size
before the flush interval is hit batches are continuously ready for writing.
When batches are called it resets the flush interval. This results in the
flush interval event getting starved and never called.
To the end users this looks like the Telegraf buffer always increasing.
This is because the full write is never called, only batch write. The
only way at present to call write is to kill telegraf.
Resolves: #9799, #9531, #9726
Required for all PRs: