Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert reset of ticker #9800

Merged
merged 1 commit into from
Sep 30, 2021
Merged

fix: revert reset of ticker #9800

merged 1 commit into from
Sep 30, 2021

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Sep 22, 2021

Revert the previous PR. In scenarios where inputs fill the batch size
before the flush interval is hit batches are continuously ready for writing.
When batches are called it resets the flush interval. This results in the
flush interval event getting starved and never called.

To the end users this looks like the Telegraf buffer always increasing.
This is because the full write is never called, only batch write. The
only way at present to call write is to kill telegraf.

Resolves: #9799, #9531, #9726

Required for all PRs:

  • Updated associated README.md.
  • Wrote appropriate unit tests.
  • Pull request title or commits are in conventional commit format (e.g. feat: or fix:)

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Sep 22, 2021
@powersj powersj requested a review from reimda September 22, 2021 20:25
@Hipska
Copy link
Contributor

Hipska commented Sep 23, 2021

Hi @powersj does this also resolve #9531 and #9726? (If so, we should link them as well)

agent/agent.go Outdated Show resolved Hide resolved
@anatolijd
Copy link

I've installed binary from this PR and it resolved mine #9802

@Hipska Hipska linked an issue Oct 5, 2021 that may be closed by this pull request
reimda pushed a commit that referenced this pull request Oct 6, 2021
…r batch is ready. (#8953)" (#9800)

This reverts commit a6d2c4f.

(cherry picked from commit 70afc94)
@powersj powersj deleted the fix/9799 branch January 23, 2022 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug
Projects
None yet
4 participants