fix: Fix panic for non-existing metric names #9757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng node. This happens e.g. if you try to specify a constant but omit `string('...')`.
telegraf-tiger
bot
added
feat
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
sspaink
added
fix
sspaink
added
the
ready for final review
MyaLongmire
approved these changes
Sep 15, 2021
reimda
pushed a commit
that referenced
this pull request
Sep 17, 2021
(cherry picked from commit c076398)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
related to #9756
In case you specify a
metric_namewithin a parser configuration section you will actually set a query to fill the metric name. If this query references a non-existing node the code will panic as the resultingnilvalue cannot be converted tostring(see #9756). However, this might also happen in case you try to specify a constant metric name but omit thestring('...')around that name.Catch the panic before it occurs and add test cases to test it works correctly.