fix: add additional logstash output plugin stats #9707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telegraf-tiger
bot
added
the
feat
srebhan
reviewed
Sep 7, 2021
There was a problem hiding this comment.
@johnseekins I have two questions (see comments in the code) regarding your approach. From the code-side everything is fine, but I'm not sure I like the additional metrics. :-)
srebhan
reviewed
Sep 14, 2021
There was a problem hiding this comment.
@johnseekins the code looks code. Can you please add at least one test-case for the new fields to check if they are parsed as expected?
There are actually no existing tests for plugin collection in logstash 7 in the current code. I guess I'll write one for the entire thing? |
|
@johnseekins if you can do that it would be awesome! |
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
sspaink
added
fix
reimda
pushed a commit
that referenced
this pull request
Sep 17, 2021
(cherry picked from commit f5a3df4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logstash exposes some output plugin stats intermittently. We should try and grab those when they exist.