feat: Xtremio input #9697

cthiel42 · 2021-08-31T15:09:34Z

Updated associated README.md.
Wrote appropriate unit tests.
Pull request title or commits are in conventional commit format (e.g. feat: or fix:)

Input plugin for XtremIO Storage Array metrics

telegraf-tiger · 2021-09-03T15:34:40Z

Looks like new artifacts were built from this PR. Get them here!

Artifact URLs

srebhan

Hey @cthiel42, thanks for submitting this nice plugin!

I have some comments in the code. Additionally, please think about your parallelization and simplify wherever possible!

plugins/inputs/xtremio/README.md

plugins/inputs/xtremio/xtremio.go

plugins/inputs/xtremio/xtremio_test.go

srebhan · 2021-10-28T13:59:12Z

@cthiel42 any update on this PR?

cthiel42 · 2021-10-28T14:08:54Z

Hi @srebhan. I'll make the changes hopefully in the next month or two, I just haven't had the time lately.

srebhan · 2021-10-28T14:11:52Z

@cthiel42 ok thank you, just wanted to make sure there is someone caring for this code. :-)

srebhan · 2021-12-08T13:38:24Z

@cthiel42 there are still some comments open, can you please also address those?

cthiel42 · 2021-12-08T14:18:22Z

@srebhan Ya I know, I'm just picking at it when I have the time. I'll get through them all eventually.

… xmss, other code cleanup

…n due to inconsistency in the API, change how BBUs boolean metric values are set to a much cleaner way

…change in input

cthiel42 · 2021-12-10T14:11:54Z

@srebhan I commented back on a few of your comments. Can you take a look when you have the time?

srebhan

@cthiel42 nice update, thanks! I have some more comments. Please also run make fmt to pass CI tests. One remaining thing is the nested go-routines. I do understand your target, but I wonder if e.g. first querying all collectors (in parallel), then construct the sub-queries and run the subqueries (in parallel) wouldn't be a more clean approach. However, I can live with the current structure as long as you document the intention behind nesting the go-routines in the code...

plugins/inputs/xtremio/testdata_test.go

plugins/inputs/xtremio/xtremio.go

…t certain variables, various formatting

…stom tls configuration handling for http client

…rted

… xmss, other code cleanup

…n due to inconsistency in the API, change how BBUs boolean metric values are set to a much cleaner way

…change in input

…t certain variables, various formatting

…stom tls configuration handling for http client

…rted

…into xtremio_input

srebhan · 2022-01-11T09:19:46Z

@cthiel42, please take a look at the linter issues. You can reproduce them locally by running make lint-branch.

cthiel42 · 2022-01-18T20:19:59Z

@srebhan Is there anything else you need for this PR?

srebhan

@cthiel42 that's just beautiful. Sorry for not getting earlier to it!

Looks good to me.

powersj · 2022-01-28T20:53:39Z

plugins/inputs/xtremio/xtremio.go

+}
+
+func (xio *XtremIO) authenticate() error {
+	req, err := http.NewRequest("GET", xio.URL+"/api/json/v3/commands/login?password="+xio.Password+"&user="+xio.Username, nil)


Is this the only way to pass the username/password? Do these devices always use HTTPS?

These are generally going to be handled over HTTPS and likely using private IPs, but I guess that decision is ultimately up to whoever is managing the storage array. So it's possible they could be passed over HTTP.

I can also do basic auth, which probably makes more sense than query string params. Let me know if you want me to switch that over to basic auth and I can push the code. I already have it written.

@srebhan @reimda thoughts?

If basic auth (or even more advanced schemes) is supported, please use that.

telegraf-tiger · 2022-02-01T19:54:32Z

🥳 This pull request decreases the Telegraf binary size by -2.67 % for linux amd64 (new size: 134.1 MB, nightly size 137.8 MB)

📦 Looks like new artifacts were built from this PR.

Expand this list to get them here ! 🐯

Artifact URLs

DEB	RPM	TAR GZ	ZIP
amd64.deb	aarch64.rpm	darwin_amd64.tar.gz	windows_amd64.zip
arm64.deb	armel.rpm	darwin_arm64.tar.gz	windows_i386.zip
armel.deb	armv6hl.rpm	freebsd_amd64.tar.gz
armhf.deb	i386.rpm	freebsd_armv7.tar.gz
i386.deb	ppc64le.rpm	freebsd_i386.tar.gz
mips.deb	riscv64.rpm	linux_amd64.tar.gz
mipsel.deb	s390x.rpm	linux_arm64.tar.gz
ppc64el.deb	x86_64.rpm	linux_armel.tar.gz
riscv64.deb		linux_armhf.tar.gz
s390x.deb		linux_i386.tar.gz
		linux_mips.tar.gz
		linux_mipsel.tar.gz
		linux_ppc64le.tar.gz
		linux_riscv64.tar.gz
		linux_s390x.tar.gz
		static_linux_amd64.tar.gz

Chad Thielen added 3 commits August 30, 2021 15:04

Working xtremio collector. Readme and test cases coming next

6e86444

Add test cases

634ca8f

Add readme. Update metric missing collector prefix

f524610

telegraf-tiger bot added fix pr to fix corresponding bug new plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Aug 31, 2021

Chad Thielen added 2 commits August 31, 2021 10:58

formatting for CI checks

84f90bc

Update to use telegraf TLS configuration. Move variable initializations.

f038bc8

srebhan reviewed Sep 14, 2021

View reviewed changes

srebhan self-assigned this Sep 14, 2021

helenosheaa removed the fix pr to fix corresponding bug label Oct 4, 2021

Chad Thielen added 2 commits November 30, 2021 12:17

Fix README clarity, add example output

f5107c2

remove and simplify unneeded code per comments

bdf26c0

Chad Thielen added 4 commits December 8, 2021 20:07

Dont export functions, move function parameters around, rename xms to…

8572459

… xmss, other code cleanup

finish error handling for bad collector name in Init, put xmss back i…

383bf00

…n due to inconsistency in the API, change how BBUs boolean metric values are set to a much cleaner way

Add error capture when setting metrics

a0d6982

update test cases to store data in new file and use correct type for …

58daca7

…change in input

srebhan reviewed Dec 17, 2021

View reviewed changes

Chad Thielen added 5 commits December 17, 2021 13:24

Add comments for nested goroutines, moved test data files, dont expor…

cd47c7f

…t certain variables, various formatting

go fmt

f41c657

error handling changes, formatting and redundancy clean up, change cu…

9aafd61

…stom tls configuration handling for http client

various formatting

14beba9

Misinterpreted one of the comments, certain variables need to be expo…

11a4c0b

…rted

Chad Thielen added 19 commits January 6, 2022 15:59

Add test cases

000738d

Add readme. Update metric missing collector prefix

a6e5047

formatting for CI checks

486223a

Update to use telegraf TLS configuration. Move variable initializations.

2fcc8bc

Fix README clarity, add example output

2a1915e

remove and simplify unneeded code per comments

45138e1

Dont export functions, move function parameters around, rename xms to…

3b7beac

… xmss, other code cleanup

finish error handling for bad collector name in Init, put xmss back i…

7c88e23

…n due to inconsistency in the API, change how BBUs boolean metric values are set to a much cleaner way

Add error capture when setting metrics

603dbb9

update test cases to store data in new file and use correct type for …

c30af6b

…change in input

Add comments for nested goroutines, moved test data files, dont expor…

cb8356f

…t certain variables, various formatting

go fmt

fdc6a07

error handling changes, formatting and redundancy clean up, change cu…

3ed5f9a

…stom tls configuration handling for http client

various formatting

5ab2ed6

Misinterpreted one of the comments, certain variables need to be expo…

26e2e3f

…rted

Refactor to unmarshall JSON into structs instead of using gjson

a1f4fad

Various code cleanups

e974695

Merge branch 'xtremio_input' of https://github.com/cthiel42/telegraf …

5cd3dc0

…into xtremio_input

Remediate PR Lint. Naming conventions, unneeded boolean expressions

0edbf57

Resolve lint issues

bdb5baa

srebhan approved these changes Jan 24, 2022

View reviewed changes

srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jan 24, 2022

powersj reviewed Jan 28, 2022

View reviewed changes

Chad Thielen added 2 commits February 1, 2022 12:29

Switch to basic auth

de43c63

Ran make fmt

b620a62

powersj approved these changes Feb 1, 2022

View reviewed changes

powersj merged commit 6dc8e9d into influxdata:master Feb 1, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Xtremio input #9697

feat: Xtremio input #9697

cthiel42 commented Aug 31, 2021

telegraf-tiger bot commented Sep 3, 2021

Artifact URLs

srebhan left a comment

srebhan commented Oct 28, 2021

cthiel42 commented Oct 28, 2021

srebhan commented Oct 28, 2021

srebhan commented Dec 8, 2021

cthiel42 commented Dec 8, 2021

cthiel42 commented Dec 10, 2021

srebhan left a comment

srebhan commented Jan 11, 2022

cthiel42 commented Jan 18, 2022

srebhan left a comment

powersj Jan 28, 2022

cthiel42 Jan 28, 2022

powersj Jan 28, 2022

srebhan Feb 1, 2022

telegraf-tiger bot commented Feb 1, 2022

Artifact URLs

feat: Xtremio input #9697

feat: Xtremio input #9697

Conversation

cthiel42 commented Aug 31, 2021

telegraf-tiger bot commented Sep 3, 2021

Artifact URLs

srebhan left a comment

Choose a reason for hiding this comment

srebhan commented Oct 28, 2021

cthiel42 commented Oct 28, 2021

srebhan commented Oct 28, 2021

srebhan commented Dec 8, 2021

cthiel42 commented Dec 8, 2021

cthiel42 commented Dec 10, 2021

srebhan left a comment

Choose a reason for hiding this comment

srebhan commented Jan 11, 2022

cthiel42 commented Jan 18, 2022

srebhan left a comment

Choose a reason for hiding this comment

powersj Jan 28, 2022

Choose a reason for hiding this comment

cthiel42 Jan 28, 2022

Choose a reason for hiding this comment

powersj Jan 28, 2022

Choose a reason for hiding this comment

srebhan Feb 1, 2022

Choose a reason for hiding this comment

telegraf-tiger bot commented Feb 1, 2022

Artifact URLs