Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Http plugin add cookie auth #9395

Merged
merged 11 commits into from
Jul 13, 2021
Merged

Http plugin add cookie auth #9395

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b0f4c26
added cookie auth to http input
jh125486 Jun 18, 2021
7b4b167
toml config marshaller fix
jh125486 Jun 18, 2021
3199a30
toml string fix
jh125486 Jun 18, 2021
1f4eef3
moved cookie auth to plugins/common
jh125486 Jun 21, 2021
fb0275d
trying to fix tight test timing
jh125486 Jun 21, 2021
47d6d78
timing failures on darwin/win
jh125486 Jun 21, 2021
0fac36d
changes per PR comments
jh125486 Jun 22, 2021
0c86996
flakey test timing
jh125486 Jun 22, 2021
b85a911
PR fixes
jh125486 Jun 22, 2021
eac7485
logger checking
jh125486 Jun 28, 2021
abeb456
added README documentation
jh125486 Jul 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
timing failures on darwin/win
  • Loading branch information
@jh125486
jh125486 committed Jun 21, 2021
commit 47d6d78d0b6029f8aad783f3f90441fa7ada7919
8 changes: 4 additions & 4 deletions plugins/common/cookie/cookie_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,15 +85,15 @@ func (s fakeServer) checkResp(t *testing.T, expCode int) {
}
}

func (s fakeServer) checkAuthCount(t *testing.T, expCount int) {
func (s fakeServer) checkAuthCount(t *testing.T, atLeast int32) {
t.Helper()
require.EqualValues(t, expCount, atomic.LoadInt32(s.int32))
require.GreaterOrEqual(t, atomic.LoadInt32(s.int32), atLeast)
}

func TestAuthConfig_Start(t *testing.T) {
const (
renewal = 20 * time.Millisecond
renewalCheck = 55 * time.Millisecond
renewal = 10 * time.Millisecond
renewalCheck = 5 * renewal
)
type fields struct {
Method string
Expand Down