Linter fixes for plugins/inputs/[de]*

[zak-pawel]

Following findings were fixed:

plugins/inputs/dcos/client.go:236:57                             revive       import-shadowing: The name 'url' shadows an import name
plugins/inputs/dcos/client.go:262:23                             revive       import-shadowing: The name 'url' shadows an import name
plugins/inputs/dcos/client.go:276:52                             revive       import-shadowing: The name 'url' shadows an import name
plugins/inputs/dcos/client.go:321:25                             revive       import-shadowing: The name 'url' shadows an import name
plugins/inputs/dcos/client.go:322:2                              revive       import-shadowing: The name 'url' shadows an import name
plugins/inputs/dcos/dcos.go:355:2                                revive       import-shadowing: The name 'url' shadows an import name
plugins/inputs/directory_monitor/directory_monitor.go:278:43     revive       flag-parameter: parameter 'firstLine' seems to be a control flag, avoid control coupling
plugins/inputs/directory_monitor/directory_monitor_test.go:79:5  ineffassign  ineffectual assignment to err
plugins/inputs/disk/disk.go:18:2                                 revive       confusing-naming: Field 'MountPoints' differs only by capitalization to other field in the struct type DiskStats
plugins/inputs/disk/disk_test.go:113:2                           ineffassign  ineffectual assignment to err
plugins/inputs/disk/disk_test.go:118:2                           ineffassign  ineffectual assignment to err
plugins/inputs/disk/disk_test.go:1:9                             revive       import-shadowing: The name 'disk' shadows an import name
plugins/inputs/disk/disk_test.go:368:2                           ineffassign  ineffectual assignment to err
plugins/inputs/disk/disk_test.go:373:2                           ineffassign  ineffectual assignment to err
plugins/inputs/diskio/diskio.go:77:4                             revive       import-shadowing: The name 'filter' shadows an import name
plugins/inputs/diskio/diskio_linux_test.go:110:8                 revive       defer: prefer not to defer chains of function calls
plugins/inputs/diskio/diskio_linux_test.go:98:3                  revive       defer: prefer not to defer inside loops
plugins/inputs/disque/disque.go:68:3                             revive       import-shadowing: The name 'url' shadows an import name
plugins/inputs/dns_query/dns_query.go:19:2                       staticcheck  SA9004: only the first constant in this group has an explicit type
plugins/inputs/docker/client.go:1:9                              revive       import-shadowing: The name 'docker' shadows an import name
plugins/inputs/docker/docker.go:1:9                              revive       import-shadowing: The name 'docker' shadows an import name
plugins/inputs/docker/docker.go:636:1                            revive       argument-limit: maximum number of arguments per function exceeded; max 6 but got 7
plugins/inputs/docker/docker.go:880:26                           revive       flag-parameter: parameter 'perDevice' seems to be a control flag, avoid control coupling
plugins/inputs/docker/docker.go:968:2                            revive       import-shadowing: The name 'filter' shadows an import name
plugins/inputs/docker/docker.go:977:2                            revive       import-shadowing: The name 'filter' shadows an import name
plugins/inputs/docker/docker.go:989:2                            revive       import-shadowing: The name 'filter' shadows an import name
plugins/inputs/docker_log/docker_log.go:310:20                   revive       unnecessary-stmt: switch with only one case can be replaced by an if-then
plugins/inputs/docker_log/docker_log.go:424:2                    revive       import-shadowing: The name 'filter' shadows an import name
plugins/inputs/docker_log/docker_log.go:433:2                    revive       import-shadowing: The name 'filter' shadows an import name
plugins/inputs/docker_log/docker_log.go:445:2                    revive       import-shadowing: The name 'filter' shadows an import name
plugins/inputs/ecs/ecs.go:223:2                                  revive       import-shadowing: The name 'filter' shadows an import name
plugins/inputs/ecs/ecs.go:232:2                                  revive       import-shadowing: The name 'filter' shadows an import name
plugins/inputs/ecs/ecs.go:253:2                                  revive       import-shadowing: The name 'filter' shadows an import name
plugins/inputs/elasticsearch/elasticsearch.go:647:8              revive       bool-literal-in-expr: omit Boolean literal in expression
plugins/inputs/elasticsearch/elasticsearch_test.go:209:2         revive       unexported-naming: the symbol IsMasterResultTokens is local, its name should start with a lowercase letter
plugins/inputs/elasticsearch/elasticsearch_test.go:247:2         revive       unexported-naming: the symbol IsNotMasterResultTokens is local, its name should start with a lowercase letter
plugins/inputs/ethtool/ethtool_linux.go:3:9                      revive       import-shadowing: The name 'ethtool' shadows an import name
plugins/inputs/ethtool/ethtool_test.go:38:3                      revive       bare-return: avoid using bare returns, please add return expressions
plugins/inputs/ethtool/ethtool_test.go:73:3                      revive       bare-return: avoid using bare returns, please add return expressions
plugins/inputs/eventhub_consumer/eventhub_consumer.go:1:9        revive       import-shadowing: The name 'eventhub' shadows an import name
plugins/inputs/exec/exec.go:1:9                                  revive       import-shadowing: The name 'exec' shadows an import name
plugins/inputs/execd/execd_test.go:142:39                        revive       import-shadowing: The name 'metric' shadows an import name

[telegraf-tiger]

Looks like new artifacts were built from this PR. Get them here!

Artifact URLs

• windows_amd64.zip

• windows_i386.zip

• darwin_amd64.tar.gz

• i386.rpm

• freebsd_i386.tar.gz

• linux_i386.tar.gz

• i386.deb

• armel.rpm

• linux_armel.tar.gz

• armel.deb

• s390x.rpm

• linux_s390x.tar.gz

• s390x.deb

• aarch64.rpm

• linux_arm64.tar.gz

• arm64.deb

• linux_mips.tar.gz

• mips.deb

• armv6hl.rpm

• freebsd_armv7.tar.gz

• linux_armhf.tar.gz

• armhf.deb

• ppc64le.rpm

• linux_ppc64le.tar.gz

• ppc64el.deb

• static_linux_amd64.tar.gz

• x86_64.rpm

• freebsd_amd64.tar.gz

• linux_amd64.tar.gz

• amd64.deb

• linux_mipsel.tar.gz

• mipsel.deb

[srebhan]

Looks good to me.

I have only one general comment about flag-parameter: parameter 'perDevice' seems to be a control flag, avoid control coupling. I'm still not sure what a good replacement pattern is for those cases. Your "fix" is just a smart exploitation of the linter weaknesses, but you are still doing the same as before... :-)

[telegraf-tiger]

Looks like new artifacts were built from this PR. Get them here!

Artifact URLs

• darwin_amd64.tar.gz

• windows_amd64.zip

• windows_i386.zip

• i386.rpm

• freebsd_i386.tar.gz

• linux_i386.tar.gz

• i386.deb

• ppc64le.rpm

• linux_ppc64le.tar.gz

• ppc64el.deb

• linux_mipsel.tar.gz

• mipsel.deb

• linux_mips.tar.gz

• mips.deb

• s390x.rpm

• linux_s390x.tar.gz

• s390x.deb

• static_linux_amd64.tar.gz

• aarch64.rpm

• linux_arm64.tar.gz

• arm64.deb

• armv6hl.rpm

• freebsd_armv7.tar.gz

• linux_armhf.tar.gz

• armhf.deb

• x86_64.rpm

• freebsd_amd64.tar.gz

• linux_amd64.tar.gz

• amd64.deb

• armel.rpm

• linux_armel.tar.gz

• armel.deb

[srebhan]

LGTM.