-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closing all idle connections in docker input plugin #9243
Closing all idle connections in docker input plugin #9243
Conversation
This prevents error "too many open files" in most cases
Thanks so much for the pull request! |
1 similar comment
Thanks so much for the pull request! |
!signed-cla |
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
Hey guys, any feedback on this small bug fix? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Everything looks good to me.
This prevents error "too many open files" in most cases (cherry picked from commit 905b22c)
This prevents error "too many open files" in most cases
Required for all PRs:
resolves #9242
Method
Close()
of official docker client just closes all idle connections and don't destroy client instance itself:https://github.com/moby/moby/blob/17.05.x/client/client.go#L181
So it's safe to use inside telegraf input plugin