Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carbon2 serializer: sanitize metric name #9026

Merged

Conversation

pmalek-sumo
Copy link
Contributor

Sanitize metric name: replace problematic characters with :.

Fixes: #8974

Future PRs might introduce configuration of this feature, i.e. the character to replace with.

Required for all PRs:

  • Has appropriate unit tests.

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Mar 19, 2021
Copy link
Contributor

@telegraf-tiger telegraf-tiger bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤝 ✅ CLA has been signed. Thank you!

Copy link
Contributor

@telegraf-tiger telegraf-tiger bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@ivorybilled ivorybilled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps the 'replaceChar' should be configurable? I think it might be good to add something about this in the README if this will effect a significant number of users of this serializer

@pmalek-sumo
Copy link
Contributor Author

Perhaps the 'replaceChar' should be configurable? I think it might be good to add something about this in the README if this will effect a significant number of users of this serializer

@jagularr Done with 94558f0. PTAL

Copy link
Contributor

@telegraf-tiger telegraf-tiger bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@helenosheaa helenosheaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@helenosheaa helenosheaa merged commit 2b41a1e into influxdata:master Apr 8, 2021
jblesener pushed a commit to jblesener/telegraf that referenced this pull request Apr 18, 2021
reimda pushed a commit that referenced this pull request Apr 28, 2021
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Carbon2 serializer doesn't translate = in metric name
5 participants