Get rid of deprecated internal.{Duration,Size,Number} #8969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![telegraf-tiger[bot]](https://avatars.githubusercontent.com/in/94907?s=60&v=4){kind=small}
ssoroka
suggested changes
Mar 11, 2021
Comment on lines
+1
to
+4
| [[outputs.azure_monitor]] | ||
|
|
||
| [[outputs.azure_monitor]] | ||
| namespace_prefix = "" |
There was a problem hiding this comment.
This is factored out of the config_test which had this inlined in the code. Should I do another PR for factoring this out? Please not that additional PR will have a dependency on this PR... :-)
ssoroka
reviewed
Apr 8, 2021
| ) | ||
|
|
||
| func SMTPCTL(output string) func(string, internal.Duration, bool) (*bytes.Buffer, error) { | ||
| return func(string, internal.Duration, bool) (*bytes.Buffer, error) { | ||
| var TestTimeout = config.Duration(time.Second) |
There was a problem hiding this comment.
looks like we added this line back in after another PR removed it?
ssoroka
approved these changes
Apr 8, 2021
added 20 commits
April 9, 2021 14:14
ssoroka
approved these changes
Apr 9, 2021
jblesener
pushed a commit
to jblesener/telegraf
that referenced
this pull request
Apr 18, 2021
This was referenced Jun 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
The datatypes
internal.Sizeandinternal.Durationare replaced by theirconfigcounterparts. This PR moves the code to the new types and fix the fallout. Furthermore, I removedinternal.Numberwhich seems to be used bystatsdinput plugin only to represent afloat64.