Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct Q+A about state #8918

Merged
merged 1 commit into from
Mar 5, 2021
Merged

Conversation

thatsafunnyname
Copy link
Contributor

@thatsafunnyname thatsafunnyname commented Mar 1, 2021

Closes #8907 . After #8447 , this common question in the Starlark Processor README.md should be updated to reflect the newly available shared state.

For  influxdata#8907 .  After influxdata#8447  , this common question in the Starlark Processor README.md should be updated to reflect the newly available shared state.
Copy link
Contributor

@telegraf-tiger telegraf-tiger bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤝 ✅ CLA has been signed. Thank you!

@thatsafunnyname
Copy link
Contributor Author

make test-windows is failing inside the ci/circleci:test-go-windows check with timeouts after 10min, the go callstack mentions inotify functions:

https://app.circleci.com/pipelines/github/influxdata/telegraf/3679/workflows/9159d43a-d019-48ab-9c86-e80c9077cd69/jobs/79846/parallel-runs/0/steps/0-105

same as the nightly build:

https://app.circleci.com/pipelines/github/influxdata/telegraf/3677/workflows/96f8b3df-0093-446c-b598-7a2b1057af83/jobs/79827/parallel-runs/0/steps/0-105

and other recent builds:

https://app.circleci.com/pipelines/github/influxdata/telegraf/3676/workflows/7e09bd19-0cb1-44ac-bb76-e36daf8224c5/jobs/79818/parallel-runs/0/steps/0-105

FAIL github.com/influxdata/telegraf/plugins/inputs/tail 600.110s

Probably because of #8844 "Move windows tests to circle-ci, remove appveyor".

As was done in #8414 for other plugins, maybe adding // +build !windows to the start of plugins/inputs/tail_test.go is needed to skip the tail test until it can be fixed.

@ivorybilled
Copy link
Contributor

You're right, gonna see if I can fix that

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@srebhan srebhan added ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. area/starlark labels Mar 2, 2021
@srebhan srebhan self-assigned this Mar 2, 2021
@helenosheaa helenosheaa merged commit 1b7f445 into influxdata:master Mar 5, 2021
@thatsafunnyname thatsafunnyname deleted the patch-1 branch March 5, 2021 15:27
ssoroka pushed a commit that referenced this pull request Mar 10, 2021
(cherry picked from commit 1b7f445)
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/starlark ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correct common question in the Starlark Processor README about shared state.
4 participants