Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Event Log support for Windows #8616

Merged
merged 9 commits into from
Jan 19, 2021
Merged

Conversation

ivorybilled
Copy link
Contributor

This should add support to be able to configure the following in telegraf.conf:

logtarget = "eventlog"

Currently it only works when running telegraf as an already-installed windows service. This should enable it to work always, as long as it's configured and running on a windows machine.

resolves #7487

@sjwang90 sjwang90 added area/windows Related to windows plugins (win_eventlog, win_perf_counters, win_services) platform/windows feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin labels Jan 11, 2021
Copy link
Contributor

@ssoroka ssoroka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this cause any problems with telegraf's logging output?

cmd/telegraf/telegraf_windows.go Outdated Show resolved Hide resolved
logger/event_logger.go Outdated Show resolved Hide resolved
logger/event_logger.go Outdated Show resolved Hide resolved
@ivorybilled ivorybilled merged commit 1bf5a19 into master Jan 19, 2021
@ivorybilled ivorybilled deleted the addEventLogSupportWindows branch January 19, 2021 16:03
ssoroka pushed a commit that referenced this pull request Jan 27, 2021
* Add event log support for windows when not running as a windows service.

* Add error message for initializing event logger.

* Add build windows flag.

* Only register event logger when running telegraf under windows.

* Update logger/event_logger.go

Co-authored-by: Steven Soroka <ssoroka@influxdata.com>

* Remove unnecessary 'fmt' import

* Remove unnecessary 'fmt' import

* Remove unnecessary error check

* use constants for eid levels.

Co-authored-by: Steven Soroka <ssoroka@influxdata.com>
(cherry picked from commit 1bf5a19)
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
* Add event log support for windows when not running as a windows service.

* Add error message for initializing event logger.

* Add build windows flag.

* Only register event logger when running telegraf under windows.

* Update logger/event_logger.go

Co-authored-by: Steven Soroka <ssoroka@influxdata.com>

* Remove unnecessary 'fmt' import

* Remove unnecessary 'fmt' import

* Remove unnecessary error check

* use constants for eid levels.

Co-authored-by: Steven Soroka <ssoroka@influxdata.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/windows Related to windows plugins (win_eventlog, win_perf_counters, win_services) feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin platform/windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows: Unsupported logtarget: eventlog, using stderr
3 participants