-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Event Log support for Windows #8616
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjwang90
added
area/windows
Related to windows plugins (win_eventlog, win_perf_counters, win_services)
platform/windows
feat
Improvement on an existing feature such as adding a new setting/mode to an existing plugin
labels
Jan 11, 2021
ssoroka
suggested changes
Jan 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this cause any problems with telegraf's logging output?
Co-authored-by: Steven Soroka <ssoroka@influxdata.com>
ssoroka
approved these changes
Jan 19, 2021
ssoroka
pushed a commit
that referenced
this pull request
Jan 27, 2021
* Add event log support for windows when not running as a windows service. * Add error message for initializing event logger. * Add build windows flag. * Only register event logger when running telegraf under windows. * Update logger/event_logger.go Co-authored-by: Steven Soroka <ssoroka@influxdata.com> * Remove unnecessary 'fmt' import * Remove unnecessary 'fmt' import * Remove unnecessary error check * use constants for eid levels. Co-authored-by: Steven Soroka <ssoroka@influxdata.com> (cherry picked from commit 1bf5a19)
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
* Add event log support for windows when not running as a windows service. * Add error message for initializing event logger. * Add build windows flag. * Only register event logger when running telegraf under windows. * Update logger/event_logger.go Co-authored-by: Steven Soroka <ssoroka@influxdata.com> * Remove unnecessary 'fmt' import * Remove unnecessary 'fmt' import * Remove unnecessary error check * use constants for eid levels. Co-authored-by: Steven Soroka <ssoroka@influxdata.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/windows
Related to windows plugins (win_eventlog, win_perf_counters, win_services)
feat
Improvement on an existing feature such as adding a new setting/mode to an existing plugin
platform/windows
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should add support to be able to configure the following in telegraf.conf:
logtarget = "eventlog"
Currently it only works when running telegraf as an already-installed windows service. This should enable it to work always, as long as it's configured and running on a windows machine.
resolves #7487