fix issue with mqtt concurrent map write #8562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srebhan
reviewed
Dec 15, 2020
srebhan
approved these changes
Dec 15, 2020
srebhan
reviewed
Dec 16, 2020
| "github.com/eclipse/paho.mqtt.golang" | ||
| mqtt "github.com/eclipse/paho.mqtt.golang" |
There was a problem hiding this comment.
Could you please elaborate on why this is necessary!?
There was a problem hiding this comment.
this was automatically added by the formatting library, (I think goreturns, in this case). It doesn't like the implicit import of the mqtt package via a path that doesn't match the package name.
There was a problem hiding this comment.
Ok so this was my "TIL". :-) Thanks for the explanation!
srebhan
approved these changes
Dec 16, 2020
srebhan
added
ready for final review
ssoroka
added a commit
that referenced
this pull request
Dec 16, 2020
(cherry picked from commit e39208d)
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7581