Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable kafka zstd compression and idempotent writes #8435

Merged
merged 12 commits into from
Nov 23, 2020
Merged

Enable kafka zstd compression and idempotent writes #8435

merged 12 commits into from
Nov 23, 2020

Conversation

ssoroka
Copy link
Contributor

@ssoroka ssoroka commented Nov 19, 2020

closes #7647
closes #7123

@ssoroka ssoroka requested a review from reimda November 19, 2020 16:38
reimda
reimda reviewed Nov 21, 2020
View reviewed changes
Copy link
Contributor

@reimda reimda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I like how you factored out common settings.

plugins/inputs/kafka_consumer/README.md Outdated Show resolved Hide resolved
plugins/inputs/kafka_consumer/kafka_consumer.go Show resolved Hide resolved
plugins/outputs/kafka/kafka.go Outdated Show resolved Hide resolved
plugins/outputs/kafka/README.md Outdated Show resolved Hide resolved
plugins/outputs/kafka/README.md Outdated Show resolved Hide resolved
plugins/inputs/kafka_consumer/kafka_consumer.go Outdated Show resolved Hide resolved
plugins/inputs/kafka_consumer/kafka_consumer.go Outdated Show resolved Hide resolved
plugins/inputs/kafka_consumer/README.md Outdated Show resolved Hide resolved
ssoroka and others added 8 commits November 20, 2020 19:18
@ssoroka @reimda
Update plugins/outputs/kafka/kafka.go
8302069 
Co-authored-by: reimda <reimda@users.noreply.github.com>
@ssoroka @reimda
Update plugins/outputs/kafka/README.md
0ff17f3 
Co-authored-by: reimda <reimda@users.noreply.github.com>
@ssoroka @reimda
Update plugins/inputs/kafka_consumer/README.md
1158646 
Co-authored-by: reimda <reimda@users.noreply.github.com>
@ssoroka @reimda
Update plugins/outputs/kafka/README.md
5855203 
Co-authored-by: reimda <reimda@users.noreply.github.com>
@ssoroka @reimda
Update plugins/inputs/kafka_consumer/README.md
fbf516a 
Co-authored-by: reimda <reimda@users.noreply.github.com>
@ssoroka @reimda
Update plugins/inputs/kafka_consumer/kafka_consumer.go
2c2a03b 
Co-authored-by: reimda <reimda@users.noreply.github.com>
@ssoroka @reimda
Update plugins/inputs/kafka_consumer/kafka_consumer.go
79b99c2 
Co-authored-by: reimda <reimda@users.noreply.github.com>
@ssoroka
log warning if enable_tls is used
3339c01
@ssoroka ssoroka merged commit 8b30bb9 into master Nov 23, 2020
@ssoroka ssoroka deleted the kafka-zstd branch November 23, 2020 20:52
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
@ssoroka
Enable kafka zstd compression and idempotent writes (influxdata#8435)
17cc362
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reimda reimda reimda left review comments

Assignees
No one assigned
Labels
area/kafka
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable idempotence for Kafka output plugin (partial exactly-once support) Support Kafka zstd compression
3 participants
@ssoroka @reimda @sjwang90