Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add processes status stats in system input plugin #798

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 61 additions & 0 deletions plugins/inputs/system/processes.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
package system

import (
"fmt"
"log"

"github.com/influxdata/telegraf"
"github.com/influxdata/telegraf/plugins/inputs"
"github.com/shirou/gopsutil/process"
)

type Processes struct {
}

func (_ *Processes) Description() string {
return "Get the number of processes and group them by status (Linux only)"
}

func (_ *Processes) SampleConfig() string { return "" }

func (s *Processes) Gather(acc telegraf.Accumulator) error {
pids, err := process.Pids()
if err != nil {
return fmt.Errorf("error getting pids list: %s", err)
}
// TODO handle other OS (Windows/BSD/Solaris/OSX)
fields := map[string]interface{}{
"paging": uint64(0),
"blocked": uint64(0),
"zombie": uint64(0),
"stopped": uint64(0),
"running": uint64(0),
"sleeping": uint64(0),
}
for _, pid := range pids {
process, err := process.NewProcess(pid)
if err != nil {
log.Printf("Can not get process %d status: %s", pid, err)
continue
}
status, err := process.Status()
if err != nil {
log.Printf("Can not get process %d status: %s\n", pid, err)
continue
}
_, exists := fields[status]
if !exists {
log.Printf("Status '%s' for process with pid: %d\n", status, pid)
continue
}
fields[status] = fields[status].(uint64) + uint64(1)
}

acc.AddFields("processes", fields, nil)
return nil
}
func init() {
inputs.Add("processes", func() telegraf.Input {
return &Processes{}
})
}
21 changes: 21 additions & 0 deletions plugins/inputs/system/processes_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
package system

import (
"testing"

"github.com/influxdata/telegraf/testutil"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)

func TestProcesses(t *testing.T) {
processes := &Processes{}
var acc testutil.Accumulator

err := processes.Gather(&acc)
require.NoError(t, err)

assert.True(t, acc.HasUIntField("processes", "running"))
assert.True(t, acc.HasUIntField("processes", "sleeping"))
assert.True(t, acc.HasUIntField("processes", "stopped"))
}