-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove trailing backslash from tag keys/values #7652
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be documented. I expected a note in the serializer readme and maybe links in the output plugins readmes to see details in the serializer readme. I took a quick look and didn't find anything about float nan and inf being dropped either.
I added documentation about these corner cases. |
Currently a tag key or value with a trailing backslash will produce an error like:
With this change the trailing slashes are stripped. Other methods were considered include using a space or a replacement char such as
_
. I decided not to use a space since it might cause confusion when writing queries by hand and in the cli. I decided against underscore because due to how ugly it is.I know ideally we would have some form of influxdata/influxdb#6037, but I believe this needs to be worked out separately from a fix for the current line protocol.
closes #7558
Required for all PRs: