Add Prometheus parser and Kubernetes input plugin #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| func TestParseLineInvalidPrometheus(t *testing.T) { | ||
| parser := PrometheusParser{} | ||
| metric, err := parser.ParseLine(validUniqueLine) | ||
| assert.NotNil(t, err) |
There was a problem hiding this comment.
change these to just one: assert.NoError
|
@sparrc Thanks for your review ! (I think I have to stop 3 AM code ...) BTW, I feel that plugin maybe not Kubernetes specific... I could configure prometheus input plugin to get basically the same result ... maybe I should make more work to get better metric ? |
|
@titilambert I agree I think it would be better to try to improve the prometheus input plugin to get this information, if possible |
|
Closing because of improving prometheus plugin #707 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello !
This plugin does not use k8s client lib. It uses Prometheus client lib.
I also add the Prometheus parser.
@sparrc maybe you prefer I split the PR ? (Prometheus parser/Kubernetes input plugin)