Add the pg_stat_bgwriter view #683
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add pg_stat_bg_writer stats
Fix the postgresql_test.go to add the bgwriter stats
|
unit tests need to be updated for this |
|
Hi Thanls for the feedback, I already saw the unit test result. But I'm still dealing with a global column list slice which seems to be the issue. I'm new to golang it can take time. Any help would be appreciated, I have more query to add.... Thanks |
|
OK I finally completed correctly the test plan |
geodimm
pushed a commit
to miketonks/telegraf
that referenced
this pull request
Mar 10, 2016
Add pg_stat_bg_writer stats closes influxdata#683
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I am adding more metrics on the postgresql plugin, my first one is the pg_stat_bgwriter view useful to get some performance informations.
In order to keep a small code, I've setup a check in the accRow function because this view don't provide the dbname (that's a cluster view).
As those metrics are purely system, the dbname is set to postgres dbname which can make sense.
Don't hesitate to give me a feedback even if it's bad :)
I am planning to implement more stats