Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gopsutil #6212

Merged
merged 2 commits into from
Aug 6, 2019
Merged

Update gopsutil #6212

merged 2 commits into from
Aug 6, 2019

Conversation

danielnelson
Copy link
Contributor

closes #6103

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@danielnelson danielnelson added this to the 1.12.0 milestone Aug 6, 2019
@danielnelson danielnelson merged commit e65324d into master Aug 6, 2019
@danielnelson danielnelson deleted the gopsutil-2.19.7 branch August 6, 2019 05:48
bitcharmer pushed a commit to bitcharmer/telegraf that referenced this pull request Oct 18, 2019
@adrianlzt
Copy link
Contributor

This PR updates Gopkg.lock but does not update Gopkg.toml.
Is that an error?

Currently in master:

Gopkg.toml

[[constraint]]
  name = "github.com/shirou/gopsutil"
  version = "2.18.12"

Gopkg.lock

[[projects]]
  digest = "1:55dcddb2ba6ab25098ee6b96f176f39305f1fde7ea3d138e7e10bb64a5bf45be"
  name = "github.com/shirou/gopsutil"
  packages = [
    "cpu",
    "disk",
    "host",
    "internal/common",
    "load",
    "mem",
    "net",
    "process",
  ]
  pruneopts = ""
  revision = "e4ec7b275ada47ca32799106c2dba142d96aaf93"
  version = "v2.19.8"

@adrianlzt
Copy link
Contributor

An important change also coming with this update is a change in disk device names in this commit.

Previously:

> disk,device=mapper/vg00-lvusr,path=/usr ...

After the new gopsutil version:

> disk,device=dm-2,path=/usr

@danielnelson
Copy link
Contributor Author

This PR updates Gopkg.lock but does not update Gopkg.toml.
Is that an error?

In this case yes, we need to update the toml to the version of gopsutil that has the SUnreclaim field. I'm fixing this in #6716.

An important change also coming with this update is a change in disk device names in this commit.

Thanks for the heads up, I'm still looking into this but we may want to use func (s *DiskIO) diskName(devName string) like code to deal with this.

@danielnelson
Copy link
Contributor Author

I think since the disk device name change was included in 1.12.0 and we are getting ready to release 1.13, it will be best at this point to not attempt to work around the change anymore.

athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
idohalevi pushed a commit to idohalevi/telegraf that referenced this pull request Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[linux] inputs.mem: SlabReclaimable and SlabUnreclaim
2 participants