Bind input plugin #5653
Merged
Bind input plugin #5653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Modernise error handling with respect to GatherUrl * Comment out config defaults and implement default URL
* Also add better quality v3 XML sample stats, and more stringent v3 tests. * Minor correction to README wrt which BIND version supports which XML stats format.
… via separate URLs
…y be unreasonably large
…roken-out subset URLs
…espective code paths
single bind_counter is split to few different measurements for better graphing (tested on Grafana).
Now all values are put into one serie.
|
@danielnelson I think it's complete now, tests fixed and passed :) |
danielnelson
suggested changes
Apr 2, 2019
danielnelson
approved these changes
Apr 3, 2019
3 tasks
|
Thanks @danielllek and @dswarbrick, it's merged! |
dupondje
pushed a commit
to dupondje/telegraf
that referenced
this pull request
Apr 22, 2019
hwaastad
pushed a commit
to hwaastad/telegraf
that referenced
this pull request
Jun 13, 2019
Closed
bitcharmer
pushed a commit
to bitcharmer/telegraf
that referenced
this pull request
Oct 18, 2019
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up on #2383
Required for all PRs: