Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented LUN to datasource translation #4934

Merged
merged 2 commits into from
Nov 2, 2018
Merged

Implemented LUN to datasource translation #4934

merged 2 commits into from
Nov 2, 2018

Conversation

prydin
Copy link
Contributor

@prydin prydin commented Oct 29, 2018

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

Resolving issue #4855 by adding a human readable tag named dsname to all datasource instances in VMs and hosts. This should NOT increase cardinality, since it has a 1:1 relationship to lun. We decided to keep the original lun tag for backward compatibility.

@glinton glinton added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin area/vsphere labels Oct 29, 2018
@glinton glinton added this to the 1.8.3 milestone Oct 29, 2018
@danielnelson danielnelson modified the milestones: 1.8.3, 1.9.0 Oct 30, 2018
@danielnelson danielnelson merged commit 69170d2 into influxdata:master Nov 2, 2018
otherpirate pushed a commit to otherpirate/telegraf that referenced this pull request Mar 15, 2019
otherpirate pushed a commit to otherpirate/telegraf that referenced this pull request Mar 15, 2019
dupondje pushed a commit to dupondje/telegraf that referenced this pull request Apr 22, 2019
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/vsphere feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants