Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump sarama to version 1.18.0 to support Kafka 2.0 #4676

Merged
merged 1 commit into from
Sep 12, 2018
Merged

Bump sarama to version 1.18.0 to support Kafka 2.0 #4676

merged 1 commit into from
Sep 12, 2018

Conversation

wingyplus
Copy link
Contributor

Fixes #4588

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

glinton
glinton suggested changes Sep 11, 2018
View reviewed changes
Copy link
Contributor

@glinton glinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you re-add the dependency using dep v0.5.0 to avoid the excessive changes to gopkg.lock

@glinton glinton added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin area/kafka labels Sep 11, 2018
@wingyplus
Copy link
Contributor Author

@glinton Sure. Let me fix this.

@wingyplus
Copy link
Contributor Author

@glinton fixed.

@danielnelson danielnelson added this to the 1.8.0 milestone Sep 12, 2018
@danielnelson danielnelson merged commit 9c9a5f8 into influxdata:master Sep 12, 2018
rgitzel pushed a commit to rgitzel/telegraf that referenced this pull request Oct 17, 2018
@wingyplus @rgitzel
Use sarama version 1.18.0 to support Kafka 2.0 (influxdata#4676)
37e8f8a
otherpirate pushed a commit to otherpirate/telegraf that referenced this pull request Mar 15, 2019
@wingyplus @otherpirate
Use sarama version 1.18.0 to support Kafka 2.0 (influxdata#4676)
af2ddab
otherpirate pushed a commit to otherpirate/telegraf that referenced this pull request Mar 15, 2019
@wingyplus @otherpirate
Use sarama version 1.18.0 to support Kafka 2.0 (influxdata#4676)
bde0658
dupondje pushed a commit to dupondje/telegraf that referenced this pull request Apr 22, 2019
@wingyplus
Use sarama version 1.18.0 to support Kafka 2.0 (influxdata#4676)
0b8eb34
@wingyplus wingyplus deleted the sarama_1_18_0 branch May 19, 2019 05:46
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
@wingyplus
Use sarama version 1.18.0 to support Kafka 2.0 (influxdata#4676)
132febd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glinton glinton glinton approved these changes

@danielnelson danielnelson danielnelson approved these changes

Assignees
No one assigned
Labels
area/kafka feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@wingyplus @danielnelson @glinton