Limit wait time for writes in mqtt output #3699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielnelson
commented
Jan 19, 2018
| @@ -25,6 +26,9 @@ var sampleConfig = ` | |||
| # username = "telegraf" | |||
| # password = "metricsmetricsmetricsmetrics" | |||
|
|
|||
| ## Timeout for write operations. default: 5s | |||
| # timeout = "5s" | |||
There was a problem hiding this comment.
This option already existed but was undocumented and unused.
|
@danielnelson Can we have this code checked in v1.5.2? |
danielnelson
added a commit
that referenced
this pull request
Jan 22, 2018
(cherry picked from commit 91fc276)
codesmith14
pushed a commit
to signalfx/telegraf
that referenced
this pull request
Jun 19, 2018
(cherry picked from commit 91fc276)
maxunt
pushed a commit
that referenced
this pull request
Jun 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By limiting the amount of time we will wait for message to be sent, we avoid deadlock in the mqtt output.
closes #3697
Required for all PRs: