Log connect error only in wavefront output #3549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielnelson
added a commit
that referenced
this pull request
Dec 6, 2017
(cherry picked from commit 177e7e2)
skord
pushed a commit
to skord/telegraf
that referenced
this pull request
Dec 7, 2017
aromeyer
pushed a commit
to aromeyer/telegraf
that referenced
this pull request
May 19, 2018
codesmith14
pushed a commit
to signalfx/telegraf
that referenced
this pull request
Jun 19, 2018
(cherry picked from commit 177e7e2)
maxunt
pushed a commit
that referenced
this pull request
Jun 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an error is returned from an output plugins Connect function, the Agent will connect once and if it fails again the agent will exit. This behavior should probably be altered in the Output interface, so that the Connect function becomes an initialization function. I'm planning to add an initialization function in #272 and will then revisit if the Connect function should then be removed.
In the meantime, we can log the error and return nil. This plugin will attempt reconnect on every Write.
cc @puckpuck
closes #3545
Required for all PRs:
Associated README.md updated.