Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update net response #3455

Merged
merged 2 commits into from
May 8, 2018
Merged

Update net response #3455

merged 2 commits into from
May 8, 2018

Conversation

morfien101
Copy link
Contributor

Deprecating result_type as a field value in favor of result_text as a tag value.
Adding a field value called result_code which is an int in the fields.
Updating tests to reflect changes.
Adding new tests to test other sections of the code.
Updating the README.me file to reflect the changes.

Required for all PRs:

  • [ x ] Signed CLA.
  • [ x ] Associated README.md updated.
  • [ x ] Has appropriate unit tests.

…result_type.

Deprecating result_type as a field value in favor of result_text as a tag value.
Adding a field value called result_code which is an int in the fields.
Updating tests to reflect changes.
Adding new tests to test other sections of the code.
Updating the README.me file to reflect the changes.
@morfien101
Copy link
Contributor Author

@danielnelson Is there any word on when this will be released ? We are waiting on the release to push it out into our estate.

@danielnelson
Copy link
Contributor

We could add the result_code field for 1.5, but I'd like to have more discussion and consensus with respect to adding the tag.

@tzz
Copy link
Contributor

tzz commented Mar 7, 2018

This would be great for Prometheus users.

@danielnelson danielnelson changed the base branch from master to update_net_response May 8, 2018 23:06
@danielnelson danielnelson merged commit 5953db8 into influxdata:update_net_response May 8, 2018
@danielnelson
Copy link
Contributor

I followed this pull request up with some minor changes to match style with http_response and dns_query plugins: fa04e53

@danielnelson danielnelson added this to the 1.7.0 milestone May 8, 2018
jvrahav pushed a commit to jvrahav/telegraf that referenced this pull request May 9, 2018
jvrahav pushed a commit to jvrahav/telegraf that referenced this pull request May 9, 2018
arkady-emelyanov pushed a commit to arkady-emelyanov/telegraf that referenced this pull request May 18, 2018
otherpirate pushed a commit to otherpirate/telegraf that referenced this pull request Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants