Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix documented equation for diskio average queue depth #3334

Merged
merged 1 commit into from
Oct 12, 2017
Merged

fix documented equation for diskio average queue depth #3334

merged 1 commit into from
Oct 12, 2017

Conversation

phemmer
Copy link
Contributor

@phemmer phemmer commented Oct 12, 2017

I got the documented equation wrong for calculating the average queue depth. I based it off the equation in iostat, but the iostat /1000 was for the time unit conversion. For us this is handled by the derivative(..., 1ms).

Demonstration of the correct equation:
image

# iostat -t -d -x 15 /dev/sdb
Linux 3.10.0-514.21.2.el7.x86_64 (fll2gdbs10stg) 	10/12/17 	_x86_64_	(2 CPU)

...

10/12/17 17:08:32
Device:         rrqm/s   wrqm/s     r/s     w/s    rkB/s    wkB/s avgrq-sz avgqu-sz   await r_await w_await  svctm  %util
sdb               0.00     4.47 1479.13   12.33 756996.80   117.33  1015.26     9.39    6.30    6.34    1.26   0.65  96.96

10/12/17 17:08:47
Device:         rrqm/s   wrqm/s     r/s     w/s    rkB/s    wkB/s avgrq-sz avgqu-sz   await r_await w_await  svctm  %util
sdb               0.00     3.13 1602.20   13.07 820326.40   129.87  1015.88    10.37    6.42    6.47    0.91   0.60  97.19

10/12/17 17:09:02
Device:         rrqm/s   wrqm/s     r/s     w/s    rkB/s    wkB/s avgrq-sz avgqu-sz   await r_await w_await  svctm  %util
sdb               0.00     2.60 1741.87   10.80 891801.87   105.07  1017.77    10.57    6.03    6.06    0.83   0.55  96.77

@danielnelson danielnelson merged commit bed14e5 into influxdata:master Oct 12, 2017
@danielnelson danielnelson added this to the 1.5.0 milestone Oct 12, 2017
@danielnelson danielnelson added the docs Issues related to Telegraf documentation and configuration descriptions label Oct 12, 2017
@phemmer phemmer deleted the diskio-eqn-avg-queue-depth branch October 12, 2017 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Issues related to Telegraf documentation and configuration descriptions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants