Fixed #3162 fix parsing of SHM remotes #3163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added test cases for SHM remotes; - slightly changed the fix for influxdata#2386 to improve and fix the parsing of SHM remotes.
plugins/inputs/ntpq/ntpq_test.go
Outdated
| "stratum": "2", | ||
| "type": "u", | ||
| } | ||
| acc.AssertContainsTaggedFields(t, "ntpq", fields, tags) |
There was a problem hiding this comment.
Why is this code removed?
There was a problem hiding this comment.
A combination of fat fingers and a lack of caffeine. Should not be removed at all. I've reverted that change...
Due to the changes of influxdata#3162.
danielnelson
pushed a commit
that referenced
this pull request
Aug 25, 2017
(cherry picked from commit d449833)
maxunt
pushed a commit
that referenced
this pull request
Jun 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs: