fix race in testutil Accumulator.Wait() #2598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about in ClearMetrics()? |
|
Good catch. updated |
|
I wouldn't bother with the changelog since it only affects developers. |
|
Removed (forgot to go back and add PR number anyway :-P ) |
calerogers
pushed a commit
to calerogers/telegraf
that referenced
this pull request
Apr 5, 2017
vlamug
pushed a commit
to vlamug/telegraf
that referenced
this pull request
May 30, 2017
maxunt
pushed a commit
that referenced
this pull request
Jun 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this in a test result for #2587: https://circleci.com/gh/influxdata/telegraf/6432?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link
What happens is that the accumulator has 2 metrics in it,
Wait(3)is called and grabs a lock. Then another goroutine adds a metric, increments the atomic counter, and blocks waiting for the lock. The first goroutine, which is still running, gets to the point in the code where it checks the atomic counter, sees3, and returns, releasing the lock. This frees up the second goroutine, but it doesn't get scheduled on the CPU yet. The caller ofWait(3)then tries to access the 3rd metric, but the second goroutine didn't get a chance to add it yet.Required for all PRs: