DEAD (X) State Process #2501
DEAD (X) State Process #2501
Conversation
Following https://github.com/torvalds/linux/blob/master/fs/proc/array.c#L126 telegraf plugin should handle DEAD state process and possibility to see it (http://unix.stackexchange.com/questions/126101/possible-to-see-dead-proccesses) specially in Docker context, the X state should be handle (I think this should be process like zombies but if you consider another metrics is necessary I can add it to interface)
|
Looks good, go ahead and update CHANGELOG.md. |
add reference in change log to issue/pr
|
Done |
|
Shouldn't this be a separate counter? Zombies aren't dead, they're undead!! ;) (seriously though, I think it should be a separate "dead" counter) |
|
^^ the man page report "(should never be seen)" but from my experience process with short time life especially in container context can appear with X state... and their behavior is near than zombie... but you have right we should be able to monitor dead counter and zombie counter independently |
|
done |
|
We should update this list too: https://github.com/influxdata/telegraf/blame/master/plugins/inputs/system/PROCESSES_README.md#L31 |
|
thanks for pointer this is update |
| @@ -39,6 +40,7 @@ Linux FreeBSD Darwin meaning | |||
| R R R running | |||
| S S S sleeping | |||
| Z Z Z zombie | |||
| X X X dead | |||
There was a problem hiding this comment.
Is this correct? I think it should be X none none based on manpages I've found online.
There was a problem hiding this comment.
If I read https://www.freebsd.org/cgi/man.cgi?ps(1)
X The process is being traced or debugged.
similar on http://www.manpages.info/macosx/ps.1.html
There was a problem hiding this comment.
This switch is only over the first character though, and as I read it X cannot be the first char on these other platforms.
No really Dead state on this platform
plugins/inputs/system/processes.go
Outdated
| @@ -66,6 +66,7 @@ func getEmptyFields() map[string]interface{} { | |||
| fields := map[string]interface{}{ | |||
| "blocked": int64(0), | |||
| "zombies": int64(0), | |||
| "dead": int64(0), | |||
There was a problem hiding this comment.
Lets put this below in the linux case
Report count of processes in dead (X) process state from the processes input. This process state is only valid on Linux.
Report count of processes in dead (X) process state from the processes input. This process state is only valid on Linux.
Report count of processes in dead (X) process state from the processes input. This process state is only valid on Linux.
Report count of processes in dead (X) process state from the processes input. This process state is only valid on Linux.
Following https://github.com/torvalds/linux/blob/master/fs/proc/array.c#L126 telegraf plugin should handle DEAD state process and possibility to see it (http://unix.stackexchange.com/questions/126101/possible-to-see-dead-proccesses) specially in Docker context, the X state should be handle (I think this should be process like zombies but if you consider another metrics is necessary I can add it to interface)
Required for all PRs: