Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit testing w/ go 1.7.1 and support enhanced wildcard dimensions #1903

Closed
wants to merge 1 commit into from

Conversation

andyday
Copy link

@andyday andyday commented Oct 15, 2016

Required for all PRs:

  • CHANGELOG.md updated (we recommend not updating this until the PR has been approved by a maintainer)
  • Sign CLA (if not already signed)
  • README.md updated (if adding a new plugin)

Changes

  1. Fixed unit testing on go 1.7.1, see make test fails because of go vet #1696
  2. Currently dimension wildcards use an all-or-nothing approach. Added support for partial wildcarding (ie. value = 'foo*' matches all values starting with foo)

@sparrc
Copy link
Contributor

sparrc commented Nov 3, 2016

from what I can tell there appears to be overlap between #1885 and #1903. I would appreciate if one of you could open an issue with a full writeup on what exactly is wrong the cloudwatch plugin.

As this plugin is particularly difficult to reproduce problems on, please be sure to include examples of requests and responses, and links to documentation where necessary.

Please also provide concrete examples that illustrate what is wrong with the current behavior of the plugin.

If I am wrong and there isn't overlap, then feel free to open two separate issues. In either case I think they need to be seen and discussed before I can accept a PR changing the behavior of this plugin.

@sparrc sparrc closed this Nov 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants