Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set reasonable defaults in ping plugin #1890

Merged
merged 1 commit into from
Oct 17, 2016
Merged

Set reasonable defaults in ping plugin #1890

merged 1 commit into from
Oct 17, 2016

Conversation

sparrc
Copy link
Contributor

@sparrc sparrc commented Oct 12, 2016 •
edited
Loading

Required for all PRs:

  • CHANGELOG.md updated (we recommend not updating this until the PR has been approved by a maintainer)
  • Sign CLA (if not already signed)
  • README.md updated (if adding a new plugin)

closes #1742

@sparrc
Copy link
Contributor Author

sparrc commented Oct 12, 2016

cc @kostasb

@kostasb
Copy link

kostasb commented Oct 13, 2016

@sparrc

My suggestion is to set PingInterval: 1.0 instead of 0.0
1.0 is the default interval for the ping utility:

-i interval
              Wait interval seconds between sending each packet.  The default is to wait for one second between each packet normally, or not to wait in flood mode. Only super-user may set interval to values less 0.2 seconds.

@sparrc sparrc force-pushed the cs1742 branch 2 times, most recently from 388bb72 to b4da486 Compare October 17, 2016 14:17
@sparrc sparrc merged commit a4e8f24 into master Oct 17, 2016
@sparrc sparrc deleted the cs1742 branch October 26, 2016 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ping input plugin timeout
2 participants
@sparrc @kostasb