graphite parser, handle multiple templates empty filter #1871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgnorton
approved these changes
Oct 10, 2016
| stars = append(stars, "*") | ||
| } | ||
| filter = strings.Join(stars, ".") | ||
| } |
There was a problem hiding this comment.
Could be shortened to:
if filter == "" {
filter = strings.TrimRight(strings.Repeat("*.", strings.Count(template, ".")), ".")
}
or
if filter == "" {
filter = strings.Repeat("*.", strings.Count(template, "."))
filter = strings.TrimRight(filter, ".")
}
There was a problem hiding this comment.
didn't know about strings.Repeat or strings.Count, thanks!
|
@dgnorton had to do a significant refactor of this, because the problem with adding a *. pattern for each template was that it fails with "over-specific" templates. I don't like this behavior, but it's what we have, so I changed it to sort the templates instead, which keeps the current behavior of matching as much as possible on an "over-specific" template. |
sparrc
force-pushed
the
cs1731
branch
3 times, most recently
from
99ac51a to
a209223
Compare
Previously, the graphite parser would simply overwrite any template that had an identical filter to a previous template. This included the empty filter. Now we will still overwrite, but first we will sort to make sure that the most "specific" template always matches. closes #1731
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
Previously, the graphite parser would simply overwrite any template that
had an identical filter to a previous template. This included the empty
filter.
This change automatically creates a "*." filter for any template
specified with an empty filter. This allows users to specify only a
template, and Telegraf will auto-match based on the most specific
template.
closes #1731