fix(internal.clock): Fix flaky TestUnalignedTicker race condition#18515
Open
skartikey wants to merge 1 commit intoinfluxdata:masterfrom
Open
fix(internal.clock): Fix flaky TestUnalignedTicker race condition#18515skartikey wants to merge 1 commit intoinfluxdata:masterfrom
skartikey wants to merge 1 commit intoinfluxdata:masterfrom
Conversation
The select/default loop with clk.Add(1s) raced with the ticker goroutine's timer.Reset() call, causing the mock clock to advance between clk.Until() and timer.Reset(), shifting the timer deadline by 1 second. Replace the select/default loop with blocking channel reads. Since Timer(0) fires immediately inside the constructor, no clock advance is needed for the first tick. Blocking on each subsequent read ensures timer.Reset() completes before the next clk.Add().
Contributor
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The select/default loop with clk.Add(1s) raced with the ticker goroutine's timer.Reset() call, causing the mock clock to advance between clk.Until() and timer.Reset(), shifting the timer deadline by 1 second.
Replace the select/default loop with blocking channel reads. Since Timer(0) fires immediately inside the constructor, no clock advance is needed for the first tick. Blocking on each subsequent read ensures timer.Reset() completes before the next clk.Add().
Checklist
Related issues
resolves #