feat(selfstat): Implement collection of plugin-internal statistics for all types #17749
Conversation
telegraf-tiger
bot
added
the
feat
| tags["alias"] = config.Alias | ||
| } | ||
|
|
||
| maps.Copy(tags, config.Tags) |
There was a problem hiding this comment.
I don't think we should do this! The target is to have the same tags as the model-level statistics...
There was a problem hiding this comment.
The model level ones will also get this. Having these tags was the first thing I think of when seeing the spec, so that input plugin stats now also could have the tags defined on the plugin. Before there was no way to get this.
Maybe that should also go into an opt-in configuration parameter?
There was a problem hiding this comment.
I don't think the currently collected statistics will have these tags added right now. You are changing the statistics (and only for the inputs) and I don't want to open that box! Please remove the copy statement!
There was a problem hiding this comment.
What about a config parameter for this? I would really like to have it, as it will make it possible to have more performant queries to the TSDB when added.
There was a problem hiding this comment.
How about removing the line from this PR and we discuss the matter in a separate PR?
|
!retry-failed |
2 participants
Summary
While #17277 implemented the
selfstat.Collector, it only added support for output plugins. This PR adds support for aggregators, inputs, parsers, processors, serializers and secret-stores.Checklist
Related issues
based on #17344
based on #17277
required for #17733