chore: Fix linter findings for revive:unused-receiver in plugins/outputs
#16338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
DStrand1
approved these changes
Jan 13, 2025
DStrand1
added
the
ready for final review
srebhan
reviewed
Jan 14, 2025
| @@ -424,7 +424,7 @@ func (a *Elasticsearch) createNewTemplate(templatePattern string) (*bytes.Buffer | |||
| return &tmpl, nil | |||
| } | |||
|
|
|||
| func (a *Elasticsearch) GetTagKeys(indexName string) (string, []string) { | |||
| func GetTagKeys(indexName string) (string, []string) { | |||
There was a problem hiding this comment.
Do we need to export this function?
There was a problem hiding this comment.
@srebhan Yes, you’re right, they can be unexported. Do you mind if I take care of this as part of fixing linter findings for revive:exported effort?
| @@ -60,7 +60,7 @@ func (*Zabbix) SampleConfig() string { | |||
| // Connect does nothing, Write() would initiate connection in each call. | |||
| // Checking if Zabbix server is alive in this step does not allow Telegraf | |||
| // to start if there is a temporal connection problem with the server. | |||
| func (z *Zabbix) Connect() error { | |||
| func (*Zabbix) Connect() error { | |||
There was a problem hiding this comment.
Given that both Connect and Close are empty, we can remove both, can't we?
There was a problem hiding this comment.
@srebhan Then this plugin would stop being an output plugin:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Address findings for revive:unused-receiver in
plugins/outputs.It is only part of the bigger work for #16190.
After all findings of this type in whole project are handled, we can enable
revive:unused-receiverrule ingolangci-lint.Checklist