Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logging): Fix duplicated prefix+attrMsg in log message when redirectLogger is used #16274

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

zmyzheng
Copy link
Contributor

@zmyzheng zmyzheng commented Dec 6, 2024

Summary

This PR fixes a small regression issue I introduced in my previous PR #16255 which adds the prefix + attrMsg to the log message twice by mistake.

The are added to the log message in line 127 so it should not be added again in line 125.

This PR removes the duplicated one.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #16273

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Dec 6, 2024
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zmyzheng and sorry for overlooking this in the reviews!

@DStrand1 DStrand1 merged commit 14eb97a into influxdata:master Dec 9, 2024
5 of 13 checks passed
@github-actions github-actions bot added this to the v1.33.0 milestone Dec 9, 2024
@zmyzheng zmyzheng changed the title fix(logging): Fix deplicated prefix+attrMsg in log message when redirectLogger is used fix(logging): Fix duplicated prefix+attrMsg in log message when redirectLogger is used Dec 9, 2024
justinwwhuang pushed a commit to justinwwhuang/telegraf_fork that referenced this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/logging fix pr to fix corresponding bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicated prefix+attrMsg in log message when redirectLogger is used
3 participants