fix(inputs.snmp_trap): Remove timeout deprecation #16145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DStrand1
added
the
ready for final review
telegraf-tiger
bot
added
fix
Hipska
reviewed
Nov 5, 2024
Comment on lines
+106
to
+108
| if s.Timeout == 0 { | ||
| s.Timeout = defaultTimeout | ||
| } |
There was a problem hiding this comment.
Why setting it if it's an unused option?
There was a problem hiding this comment.
I agree. However, I'm not sure anymore the parameter is actually unused... It is used with the netsnmp translator isn't it?
There was a problem hiding this comment.
It does seem like it's still used, so I removed the deprecation. I left the refactor in though since it is a more typical way to do things than before
DStrand1
changed the title
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes the "unused" deprecation from the timeout field as it is still used
Checklist
Related issues
resolves #16137