Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.vsphere): Add tags to VSAN ESA disks #15960

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

jaymzmac
Copy link
Contributor

@jaymzmac jaymzmac commented Oct 1, 2024

Some VSAN metrics e.g. "vsan-esa-disk-layer" and "vsan-esa-disk-scsifw" are missing "hostname" and "devicename" tags.

Fixes: #15938

@telegraf-tiger telegraf-tiger bot added area/vsphere fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Oct 1, 2024
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaymzmac thank you for your contribution! Just a request to document the invalid SSD-UUID for ESA disks in the code...

plugins/inputs/vsphere/vsan.go Show resolved Hide resolved
@srebhan srebhan self-assigned this Oct 1, 2024
@jaymzmac
Copy link
Contributor Author

jaymzmac commented Oct 2, 2024

Added a comment to the code. Unfortunately I can't find any official documentation supporting this, I've just been using my local VSAN ESA environment as a source of truth.

@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Oct 2, 2024

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jaymzmac!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Oct 2, 2024
@srebhan srebhan assigned DStrand1 and unassigned srebhan Oct 2, 2024
@DStrand1 DStrand1 merged commit e84c23c into influxdata:master Oct 2, 2024
26 of 27 checks passed
@github-actions github-actions bot added this to the v1.32.1 milestone Oct 2, 2024
srebhan pushed a commit that referenced this pull request Oct 7, 2024
Co-authored-by: James McEwan <james.mcewan@glesys.se>
(cherry picked from commit e84c23c)
asaharn pushed a commit to asaharn/telegraf that referenced this pull request Oct 16, 2024
Co-authored-by: James McEwan <james.mcewan@glesys.se>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/vsphere fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vSphere Plugin - VSAN ESA disk performance metrics missing hostname & devicename tags
3 participants