-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(inputs.vsphere): Add tags to VSAN ESA disks #15960
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jaymzmac thank you for your contribution! Just a request to document the invalid SSD-UUID for ESA disks in the code...
Added a comment to the code. Unfortunately I can't find any official documentation supporting this, I've just been using my local VSAN ESA environment as a source of truth. |
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jaymzmac!
Co-authored-by: James McEwan <james.mcewan@glesys.se> (cherry picked from commit e84c23c)
Co-authored-by: James McEwan <james.mcewan@glesys.se>
Some VSAN metrics e.g. "vsan-esa-disk-layer" and "vsan-esa-disk-scsifw" are missing "hostname" and "devicename" tags.
Fixes: #15938