Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(inputs.memcached): Add support for external-store metrics #15910

Merged
merged 2 commits into from
Sep 19, 2024
Merged

feat(inputs.memcached): Add support for external-store metrics #15910

merged 2 commits into from
Sep 19, 2024

Conversation

paulojmdias
Copy link
Contributor

Summary

Memcached supports being used with an external store, this PR enabled supports for gathering those metrics from Memcached.

Checklist

  • No AI generated code was used in this PR

@paulojmdias
feat: [inputs.memcached] add support for extstore metrics
0b69d52 
Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Sep 17, 2024
@paulojmdias paulojmdias changed the title feat: [inputs.memcached] add support for extstore metrics feat(inputs.memcached): add support for extstore metrics Sep 17, 2024
@telegraf-tiger telegraf-tiger bot added the plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins label Sep 17, 2024
@paulojmdias
fix: fix tests
bd95a78 
Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

DStrand1
DStrand1 approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@DStrand1 DStrand1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@DStrand1 DStrand1 added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Sep 17, 2024
@srebhan srebhan changed the title feat(inputs.memcached): add support for extstore metrics feat(inputs.memcached): Add support for external-store metrics Sep 19, 2024
srebhan
srebhan approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the nice PR @paulojmdias!

@srebhan srebhan merged commit 24b7b91 into influxdata:master Sep 19, 2024
29 checks passed
@github-actions github-actions bot added this to the v1.33.0 milestone Sep 19, 2024
@paulojmdias paulojmdias deleted the memcached_extstore_metrics branch September 19, 2024 09:41
asaharn pushed a commit to asaharn/telegraf that referenced this pull request Oct 16, 2024
@paulojmdias @asaharn
feat(inputs.memcached): Add support for external-store metrics (influ…
2a664a4 
…xdata#15910)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DStrand1 DStrand1 DStrand1 approved these changes

@srebhan srebhan srebhan approved these changes

Assignees

@srebhan srebhan

Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.33.0
Development

Successfully merging this pull request may close these issues.
3 participants
@paulojmdias @srebhan @DStrand1