fix(common.http): Keep timeout after creating oauth client #15900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks so much for the pull request! |
|
!signed-cla |
lestrozi
force-pushed
the
fix_http_timeout_after_oauth
branch
from
83775d6
to
77345d8
Compare
lestrozi
force-pushed
the
fix_http_timeout_after_oauth
branch
from
77345d8
to
d6430fd
Compare
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
DStrand1
changed the title
DStrand1
added
the
ready for final review
srebhan
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
@lestrozi thanks a lot for the fix! You might also want to look into the oauth2 secret-store as this provides a more general solution...
srebhan
pushed a commit
that referenced
this pull request
Oct 7, 2024
(cherry picked from commit d77cf92)
asaharn
pushed a commit
to asaharn/telegraf
that referenced
this pull request
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The HTTP client created by httpconfig loses Timeout configuration when oauth is enabled. More information on issue #15899
This is the fix with the least moving parts I could come up with.
For the future it's probably advisable to have oauth config return a properly wrapped client instead of a new client; or having a mechanism to keep the configuration of the original client.
Checklist
Related issues
resolves #15899