Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cmd): Align plugin deprecation messages #15867

Merged

Conversation

Hipska
Copy link
Contributor

@Hipska Hipska commented Sep 11, 2024

Summary

  • Aligns the plugin deprecation messages with the plugin description.
  • Skips the printing of http_listener input as that would result in having sample config printed for inputs.influxdb_listener twice, once with a very confusing deprecation message.
-#  ## DEPRECATED: The "aerospike" plugin is deprecated in version 1.30.0 and will be removed in 1.40.0, use 'inputs.prometheus' with the Aerospike Prometheus Exporter instead.
+# ## DEPRECATED: The "aerospike" plugin is deprecated in version 1.30.0 and will be removed in 1.40.0, use 'inputs.prometheus' with the Aerospike Prometheus Exporter instead.
 # # Read stats from aerospike server(s)
 # [[inputs.aerospike]]

Checklist

  • No AI generated code was used in this PR

Related issues

@telegraf-tiger telegraf-tiger bot added the chore label Sep 11, 2024
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work @Hipska!

@srebhan srebhan added area/agent ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. labels Sep 11, 2024
@Hipska Hipska marked this pull request as draft September 11, 2024 13:19
@Hipska Hipska marked this pull request as ready for review September 11, 2024 13:24
@DStrand1 DStrand1 merged commit b07d089 into influxdata:master Sep 12, 2024
29 checks passed
@github-actions github-actions bot added this to the v1.32.1 milestone Sep 12, 2024
@Hipska Hipska deleted the chore/cmd/print_config_deprecation branch September 13, 2024 07:43
srebhan pushed a commit that referenced this pull request Oct 7, 2024
asaharn pushed a commit to asaharn/telegraf that referenced this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/agent chore ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants