-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(aggregators): Comment out default values in sample configs #15864
chore(aggregators): Comment out default values in sample configs #15864
Conversation
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
!retry-failed |
@Hipska please do not add the tests here. I would suggest to add a test to |
We discussed this before when I introduced the |
I said we should be careful with the test and add a whitelist for plugins we know are different. |
So, next actions: Remove the tests? |
Yes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @Hipska!
) (cherry picked from commit dd94512)
Summary
Adds a test to validate the sample configChecklist
Related issues