-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Fix linter findings for revive:max-public-structs
in plugins/inputs/[a-n]*
#15858
chore: Fix linter findings for revive:max-public-structs
in plugins/inputs/[a-n]*
#15858
Conversation
…s/inputs/[a-n]*`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zak-pawel! Just two small comments while we are at it. I also realized that we can probably remove some non-content comments on structs but this is optional...
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zak-pawel!
Summary
Address following findings for revive:max-public-structs in
plugins/inputs/[a-g]*
:As proposed here #15822, we will fix the errors found by the following configuration:
It is only part of the bigger job.
After all findings of this type in whole project are handled, we can enable
revive:max-public-structs
rule ingolangci-lint
.Checklist