Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.amqp_consumer): NACKing messages on non-delivery related errors #15796

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Aug 30, 2024

Summary

This PR NACKs messages that cannot be parsed or processed otherwise, keeping the rejection in delivery failure cases. Messages are not requeued in both cases. Furthermore, a small notice is added to the README on how the marking works.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #15741

@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Aug 30, 2024
@srebhan srebhan self-assigned this Aug 30, 2024
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Sep 16, 2024
@srebhan srebhan assigned DStrand1 and unassigned srebhan Sep 16, 2024
@DStrand1 DStrand1 merged commit 640eda0 into influxdata:master Sep 19, 2024
27 checks passed
@github-actions github-actions bot added this to the v1.32.1 milestone Sep 19, 2024
srebhan added a commit that referenced this pull request Oct 7, 2024
asaharn pushed a commit to asaharn/telegraf that referenced this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent discarding of messages in AMQP Consumer plugin
2 participants