Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.kinesis_consumer): Honor the configured endpoint #15788

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

mskonovalov
Copy link
Contributor

Summary

Passing endpoint from config to input kinesis plugin

Otherwise running locally in docker-compose it cannot connect to kinesis

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Aug 29, 2024
@mskonovalov mskonovalov changed the title feat: add endpoint to input plugin as well feat: support endpoint in kinesis consumer Aug 29, 2024
@telegraf-tiger
Copy link
Contributor

@srebhan srebhan changed the title feat: support endpoint in kinesis consumer fix(inputs.kinesis_consumer): Honor the configured endpoint Aug 29, 2024
@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Aug 29, 2024
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for fixing this @mskonovalov!

@srebhan srebhan added ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. and removed feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin labels Aug 29, 2024
@DStrand1 DStrand1 merged commit de24c16 into influxdata:master Aug 29, 2024
31 checks passed
@github-actions github-actions bot added this to the v1.32.0 milestone Aug 29, 2024
asaharn pushed a commit to asaharn/telegraf that referenced this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants