Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(inputs.mysql): Add support for replica status #15749

Merged
merged 4 commits into from
Aug 20, 2024
Merged

feat(inputs.mysql): Add support for replica status #15749

merged 4 commits into from
Aug 20, 2024

Conversation

hungnt1
Copy link
Contributor

@hungnt1 hungnt1 commented Aug 16, 2024 •
edited by srebhan
Loading

Summary

Add replica status command when collect mysql

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #15748

@telegraf-tiger telegraf-tiger bot added area/mysql feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Aug 16, 2024
@hungnt1 hungnt1 mentioned this pull request Aug 16, 2024
Closed
srebhan
srebhan reviewed Aug 16, 2024
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @hungnt1! Two comments from my side...

plugins/inputs/mysql/mysql.go Outdated Show resolved Hide resolved
plugins/inputs/mysql/README.md Outdated Show resolved Hide resolved
@srebhan srebhan self-assigned this Aug 16, 2024
@srebhan srebhan changed the title feat(inputs.mysql): Add support gather replica status feat(inputs.mysql): Add support for replica status Aug 16, 2024
hungnt1 and others added 2 commits August 16, 2024 16:50
@hungnt1 @srebhan
Update plugins/inputs/mysql/README.md
28ba44e 
Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
@hungnt1
feat(inputs.mysql): update switch gather replica
82fa1d8
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

👍 This pull request doesn't change the Telegraf binary size

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

srebhan
srebhan approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks @hungnt1 for this nice feature!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Aug 20, 2024
@srebhan srebhan assigned powersj and DStrand1 and unassigned srebhan Aug 20, 2024
@powersj powersj merged commit 1852d75 into influxdata:master Aug 20, 2024
27 checks passed
@github-actions github-actions bot added this to the v1.32.0 milestone Aug 20, 2024
@BrewTestBot BrewTestBot mentioned this pull request Sep 9, 2024
Merged
asaharn pushed a commit to asaharn/telegraf that referenced this pull request Oct 16, 2024
@hungnt1 @asaharn
feat(inputs.mysql): Add support for replica status (influxdata#15749)
f82d06c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan approved these changes

@powersj powersj powersj approved these changes

Assignees

@powersj powersj

@DStrand1 DStrand1

Labels
area/mysql feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.32.0
Development

Successfully merging this pull request may close these issues.

feat(inputs.mysql): Add support gather replica status
4 participants
@hungnt1 @powersj @srebhan @DStrand1