Disable darwin builds

[sparrc]

Required for all PRs:

• CHANGELOG.md updated

telegraf can't be cross-compiled for darwin, it has C dependencies and
thus many of the system plugins won't work.

cc @rossmcdonald

[rossmcdonald]

@sparrc Does this mean that we won't be offering Homebrew builds for macOS? I don't think I've seen any build errors for Darwin before.

[sparrc]

it won't create build errors, but the build won't function properly. Homebrew is still available because those get built natively on osx

[rossmcdonald]

Ah, understood. LGTM.

[janxious]

but the build won't function properly.

@sparrc I know this is already merged but can you talk just a little more about this? Just curious what kinds of things you're seeing not functioning.

[sparrc]

I can't find the issue now, but I remember a user having issues with the cpu plugin

[janxious]

Word. If you run across it again, I'd like to see it. It's kinda monkeying with some build processes we are using to not have the darwin version. This PR was a surprise for us. :)

[sparrc]

is there a reason you can't use homebrew?

[tonydewan]

@sparrc I work with Joel. We're including the telegraf executables in a project to make distribution easier. We specifically want our users to have an easier time trying the project out on their development machines, and adding the extra step of brew install telegraf isn't ideal for that goal.

[sparrc]

I understand, but if you're distributing a project for development machines then it sounds like you may have the resources to build the binary yourself. Unfortunately darwin doesn't have the best support for build system VMs and Telegraf is not a purely Go project (if you consider dependencies)

[janxious]

I think I agree with you but want to clarify one thing about this particular PR: the removal of this was to remove building telegraf for binary distribution to various OSx versions, and the preferred way of building telegraf on OSX is either homebrew or build from source using make, correct?

[sparrc]

yes, correct, and BTW this was the issue: #1484

and cross-compiling from linux doesn't work because of this code in gopsutil: https://github.com/shirou/gopsutil/blob/master/cpu/cpu_darwin_cgo.go

[janxious]

Thanks @sparrc!