fix(inputs.mqtt_consumer): Restore trace logging option #15670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In influxdata#15429, I added trace logging to the mqtt outputs for v3 and v5. I removed trace logging settings from the input, moving it to the common code. However, the input does not even use the common code *facepalm*. This restores the trace option for the input.
powersj
added
the
ready for final review
telegraf-tiger
bot
added
fix
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
DStrand1
approved these changes
Jul 26, 2024
powersj
added a commit
that referenced
this pull request
Aug 12, 2024
(cherry picked from commit f9900f8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #15429, I added trace logging to the mqtt outputs for v3 and v5. I removed trace logging settings from the input, moving it to the common code. However, the input does not even use the common code facepalm. This restores the trace option for the input. I discovered this while testing out the new logging mechanisms.
Checklist