feat(agent): Watch for deleted files #15644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telegraf-tiger
bot
added
the
feat
powersj
added
the
ready for final review
|
@powersj I think we should wait a little bit to see if the files comes back after deletion e.g. if a user moves the file away and then copies a new (or the same) file into the old location. Does that make sense? |
Currently, the agent will recognize when config files are deleted and then block, waiting for them to re-appear. This will trigger a reload. This is not likely the intended behavior, instead a user wants to remove a configuration and have telegraf remove that configuration from the running Telegraf. Note this only works on watched directories. If a user specifies a specific file to load and then deletes it, Telegraf will fail to start as that file is now missing. In order to avoid any additional error messages on reload, the list of known configs needs to update as well. Therefore, right before the reload we go get a new list of files based on the CLI options + reading any configuration directories.
powersj
force-pushed
the
feat/config-delete
branch
from
836c7f3
to
5e4ab2f
Compare
powersj
commented
Jul 23, 2024
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
srebhan
approved these changes
Jul 24, 2024
DStrand1
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, the agent will recognize when config files are deleted and then block the watcher, waiting for them to re-appear. If the file shows back up, the watcher will trigger a reload. This is not likely the intended behavior, instead a user wants to remove a configuration and have telegraf remove that configuration from the running Telegraf.
Note this only works on watched directories. If a user specifies a specific file to load and then deletes it, Telegraf will fail to start as that file is now missing.
In order to avoid any additional error messages on reload, the list of known configs needs to update as well since the file was removed. Therefore, right before the reload we go get a new list of files based on the CLI options + reading any configuration directories.
Checklist
Related issues
Related to #12389
Related to #12264