Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(agent.buffer): Add experimental warnings and increased logging #15638

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

DStrand1
Copy link
Member

Summary

Adds warnings both in the docs as well as on telegraf start about the experimental status of the disk buffer. Also improves the internal and user-facing documentation. Adds extra logging to various panic calls within the disk buffer implementation for easier debugging if it occurs.

Checklist

  • No AI generated code was used in this PR

@telegraf-tiger telegraf-tiger bot added the chore label Jul 18, 2024
@DStrand1 DStrand1 force-pushed the buffer-strategy-logging-warnings branch from 48cff6a to 0a7b131 Compare July 18, 2024 20:52
@DStrand1 DStrand1 added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jul 18, 2024
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DStrand1! The code looks good, I only suggest to make the experimental message a warning to generate more attention, but I'm also fine to keep it an info if you both think this is sufficient.

config/config.go Outdated Show resolved Hide resolved
@srebhan srebhan removed their assignment Jul 19, 2024
config/config.go Outdated Show resolved Hide resolved
@telegraf-tiger
Copy link
Contributor

@powersj powersj merged commit f11ead9 into influxdata:master Jul 19, 2024
27 checks passed
@github-actions github-actions bot added this to the v1.31.2 milestone Jul 19, 2024
@DStrand1 DStrand1 deleted the buffer-strategy-logging-warnings branch October 11, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants